fix(pro:search): empty input segment should be invalid #1494
Conversation
|
This preview will be available after the AzureCI is passed. |
![cr-gpt[bot]](https://avatars.githubusercontent.com/in/292659?s=60&v=4){kind=small}
| @@ -19,7 +19,7 @@ export function createInputSegment(prefixCls: string, searchField: InputSearchFi | |||
| inputClassName: [inputClassName, `${prefixCls}-input-segment-input`], | |||
| placeholder: searchField.placeholder, | |||
| defaultValue, | |||
| parse: input => input, | |||
| parse: input => (input ? input : undefined), | |||
| format: value => (trim ? value?.trim() : value) ?? '', | |||
| } | |||
| } | |||
There was a problem hiding this comment.
the code review
The code patch looks good. It appears that the goal is to make the input value type of the createInputSegment function to a string or undefined instead of just a string.
The changes check that the input value is not null or undefined before parsing and formatting it, and they also change the return type of the createInputSegment function to string or undefined. This should help prevent any bugs related to unexpected input values.
However, it is worth noting that the parse and format functions are still expecting a string value, so further checks may be necessary if other data types are being used. Additionally, it would be helpful to add more detailed comments to the code explaining what it does and why.
Codecov Report
@@ Coverage Diff @@
## main #1494 +/- ##
=======================================
Coverage 92.73% 92.73%
=======================================
Files 331 331
Lines 30752 30752
Branches 3533 3533
=======================================
Hits 28519 28519
Misses 2233 2233 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
PR Checklist
Please check if your PR fulfills the following requirements:
What is the current behavior?
input类型搜索项，先输入，再退格清除，此时空的输入会被校验为合法
What is the new behavior?
修复以上问题，空字符串一律返回 undefined
Other information