Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp:spin): btn under ix-spin can be clicked #1499

Merged
merged 1 commit into from Mar 13, 2023

Conversation

kovsu
Copy link
Member

@kovsu kovsu commented Mar 10, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

TFNEAWOV7Y L}R5E36F$GTS

因为 ix-spin 的 pointer-events 属性为 none,所以后面的输入框和按钮都能被操作。所以我们应该给他设置成 auto

What is the new behavior?

Other information

@@ -27,6 +27,7 @@
bottom: 0;
position: absolute;
background-color: rgb(255 255 255 / 40%);
pointer-events: auto;
}
}

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the review:

The patch looks good, there is no bug risk and the code is syntactically correct. The addition of the pointer-events property ensures that the element can now receive mouse events. This should improve the user experience when interacting with the element.

@idux-bot
Copy link

idux-bot bot commented Mar 10, 2023

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Mar 10, 2023

Codecov Report

Merging #1499 (4ec5b29) into main (760b5ac) will decrease coverage by 0.07%.
The diff coverage is 90.88%.

❗ Current head 4ec5b29 differs from pull request most recent head 8e6b45d. Consider uploading reports for the commit 8e6b45d to get more accurate results

@@            Coverage Diff             @@
##             main    #1499      +/-   ##
==========================================
- Coverage   92.81%   92.75%   -0.07%     
==========================================
  Files         327      331       +4     
  Lines       30349    30801     +452     
  Branches     2547     3532     +985     
==========================================
+ Hits        28168    28568     +400     
- Misses       2181     2233      +52     
Impacted Files Coverage Δ
packages/pro/search/src/ProSearch.tsx 16.35% <15.38%> (+0.86%) ⬆️
packages/cdk/utils/src/dom.ts 78.97% <18.18%> (-8.69%) ⬇️
packages/components/cascader/src/Cascader.tsx 84.68% <63.63%> (-11.39%) ⬇️
packages/components/collapse/src/CollapsePanel.tsx 97.47% <93.75%> (-0.62%) ⬇️
packages/components/desc/src/DescItem.tsx 96.38% <96.38%> (ø)
packages/cdk/utils/src/tree.ts 98.40% <100.00%> (ø)
packages/components/cascader/src/token.ts 100.00% <100.00%> (ø)
packages/components/cascader/src/types.ts 100.00% <100.00%> (ø)
packages/components/checkbox/src/types.ts 100.00% <100.00%> (ø)
packages/components/config/src/defaultConfig.ts 100.00% <100.00%> (ø)
... and 25 more

... and 5 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@danranVm danranVm merged commit 3463cea into IDuxFE:main Mar 13, 2023
@kovsu kovsu deleted the fix-spin branch March 16, 2023 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants