Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp:cascader): group height should be same as panel height #1500

Merged
merged 1 commit into from Mar 13, 2023

Conversation

sallerli1
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

子面板group数据量比较多,撑开整体面板高度时,父级面板高度没有占满整体面板高度,导致右border高度不对
image

What is the new behavior?

修复以上问题

Other information

@@ -92,7 +92,7 @@

display: flex;
flex-wrap: nowrap;
align-items: flex-start;
align-items: stretch;
font-size: @cascader-option-font-size;
overflow: auto;
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with the review

The code patch looks good in terms of syntax. There is no risk of bug. However, if you want to avoid any potential issues in future, it is worth considering to add a comment above the line which has been changed. This will help other developers to understand why the change was made. In addition, you can add unit tests to ensure that the code works as expected.

@idux-bot
Copy link

idux-bot bot commented Mar 13, 2023

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Mar 13, 2023

Codecov Report

Merging #1500 (d466f70) into main (c217da6) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head d466f70 differs from pull request most recent head 0f9345c. Consider uploading reports for the commit 0f9345c to get more accurate results

@@            Coverage Diff             @@
##             main    #1500      +/-   ##
==========================================
+ Coverage   92.73%   92.75%   +0.01%     
==========================================
  Files         331      331              
  Lines       30752    30801      +49     
  Branches     3533     3533              
==========================================
+ Hits        28519    28568      +49     
  Misses       2233     2233              
Impacted Files Coverage Δ
packages/components/cascader/src/types.ts 100.00% <100.00%> (ø)
packages/components/checkbox/src/types.ts 100.00% <100.00%> (ø)
packages/components/date-picker/src/types.ts 100.00% <100.00%> (ø)
packages/components/form/src/types.ts 100.00% <100.00%> (ø)
packages/components/input-number/src/types.ts 100.00% <100.00%> (ø)
packages/components/input/src/types.ts 100.00% <100.00%> (ø)
packages/components/radio/src/types.ts 100.00% <100.00%> (ø)
packages/components/rate/src/types.ts 100.00% <100.00%> (ø)
packages/components/select/src/types.ts 100.00% <100.00%> (ø)
packages/components/slider/src/types.ts 100.00% <100.00%> (ø)
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@danranVm danranVm merged commit dfb5d0b into IDuxFE:main Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants