New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pro:textarea): add rows prop #1518
Conversation
This preview will be available after the AzureCI is passed. |
Codecov Report
@@ Coverage Diff @@
## main #1518 +/- ##
==========================================
- Coverage 92.77% 92.75% -0.03%
==========================================
Files 332 332
Lines 30897 30905 +8
Branches 3556 3556
==========================================
+ Hits 28666 28667 +1
- Misses 2231 2238 +7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
f138648
to
91fa563
Compare
res.push(...new Array(rows - res.length).fill(1)) | ||
} | ||
|
||
setRowCounts(res) | ||
} | ||
|
||
watch(valueRef, calcRowCounts) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the code review
-
The code could be improved by changing the line "const lines = valueRef.value?.split('\n') ?? []" to a more explicit condition like "if (valueRef.value) { const lines = valueRef.value.split('\n'); } else { const lines = []; }".
-
The code could be improved by adding an additional condition to check for the existence of the "rows" parameter before proceeding with the rest of the logic.
-
The code should also be checked for any potential bugs, such as typos, logical errors, etc.
-
The code should also be checked for any potential security risks, such as SQL Injection attacks, XSS attacks, etc.
-
The code should also be tested for performance and scalability issues.
PR Checklist
Please check if your PR fulfills the following requirements:
What is the current behavior?
What is the new behavior?
Other information