Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(comp:tabs): supoort dataSource, addable, closable #1536

Merged
merged 1 commit into from Apr 17, 2023

Conversation

danranVm
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

What is the new behavior?

  • 新增 dataSouce 的用法
  • 新增 addable, closable 以支持动态新增和删除。

Other information

@idux-bot
Copy link

idux-bot bot commented Apr 15, 2023

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Apr 15, 2023

Codecov Report

Merging #1536 (5d5906a) into main (e323867) will decrease coverage by 0.03%.
The diff coverage is 86.02%.

❗ Current head 5d5906a differs from pull request most recent head 907fd37. Consider uploading reports for the commit 907fd37 to get more accurate results

@@            Coverage Diff             @@
##             main    #1536      +/-   ##
==========================================
- Coverage   92.78%   92.76%   -0.03%     
==========================================
  Files         332      330       -2     
  Lines       30909    30601     -308     
  Branches     3557     3490      -67     
==========================================
- Hits        28678    28386     -292     
+ Misses       2231     2215      -16     
Impacted Files Coverage Δ
packages/components/select/src/Select.tsx 80.80% <ø> (-6.06%) ⬇️
packages/components/tabs/src/Tabs.tsx 80.57% <77.58%> (-19.43%) ⬇️
packages/components/tabs/src/tab.ts 100.00% <100.00%> (ø)
packages/components/tabs/src/tokens.ts 100.00% <100.00%> (ø)
packages/components/tabs/src/types.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@danranVm danranVm merged commit 0dad84b into IDuxFE:main Apr 17, 2023
3 of 7 checks passed
@danranVm danranVm deleted the feat-tabs branch April 17, 2023 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant