Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp:empty): the ids in svg should be only #1539

Merged
merged 2 commits into from Apr 23, 2023

Conversation

danranVm
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

What is the new behavior?

Other information

@idux-bot
Copy link

idux-bot bot commented Apr 20, 2023

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Merging #1539 (f91fae2) into main (c078c35) will decrease coverage by 0.11%.
The diff coverage is 99.54%.

❗ Current head f91fae2 differs from pull request most recent head d0f7724. Consider uploading reports for the commit d0f7724 to get more accurate results

@@            Coverage Diff             @@
##             main    #1539      +/-   ##
==========================================
- Coverage   92.84%   92.74%   -0.11%     
==========================================
  Files         330      330              
  Lines       30641    30642       +1     
  Branches     3511     3499      -12     
==========================================
- Hits        28450    28420      -30     
- Misses       2191     2222      +31     
Impacted Files Coverage Δ
packages/cdk/utils/src/tryOnScopeDispose.ts 95.83% <85.71%> (-4.17%) ⬇️
packages/cdk/portal/src/Portal.tsx 90.41% <100.00%> (-1.16%) ⬇️
packages/components/empty/src/Images.tsx 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@danranVm danranVm merged commit 40d25f5 into IDuxFE:main Apr 23, 2023
5 of 7 checks passed
@danranVm danranVm deleted the fix-empty-svg-id-only branch April 23, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant