Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp:button): fix icon not vertically centered #1542

Merged
merged 1 commit into from May 8, 2023

Conversation

liuzaijiang
Copy link
Contributor

@liuzaijiang liuzaijiang commented Apr 24, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

按钮中的图标没办法居中对齐
Snipaste_2023-04-24_19-28-13

What is the new behavior?

使用flex居中对齐
Snipaste_2023-04-24_19-30-29

Other information

此修改会影响到:带图标和没带图标按钮同时存在时的垂直对齐,请使用IxButtonGroup 或者 IxSpace ,或者flex样式包裹即可
image

@idux-bot
Copy link

idux-bot bot commented Apr 24, 2023

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Merging #1542 (d130de9) into main (6cd6155) will not change coverage.
The diff coverage is n/a.

❗ Current head d130de9 differs from pull request most recent head a1c0e10. Consider uploading reports for the commit a1c0e10 to get more accurate results

@@           Coverage Diff           @@
##             main    #1542   +/-   ##
=======================================
  Coverage   92.74%   92.74%           
=======================================
  Files         330      330           
  Lines       30642    30642           
  Branches     3499     3499           
=======================================
  Hits        28420    28420           
  Misses       2222     2222           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@danranVm danranVm merged commit cf269a5 into IDuxFE:main May 8, 2023
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants