Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp:tooltip): visible is not work when destroyOnHide is true #1550

Merged
merged 1 commit into from May 13, 2023

Conversation

liuzaijiang
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

<template>
    <IxTooltip title="prompt text" trigger="manual" :visible="visible" destroyOnHide>
      <IxButton @click="visible = !visible">Manual</IxButton>
    </IxTooltip>
</template>

<script lang="ts">
import { defineComponent, ref } from 'vue'

export default defineComponent({
  setup() {
    const visible = ref(false)
    return { visible }
  },
})
</script>

点击button,无法显示tooltip

What is the new behavior?

正常显示

Other information

@idux-bot
Copy link

idux-bot bot commented May 12, 2023

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented May 12, 2023

Codecov Report

Merging #1550 (369c60d) into main (64d9a34) will increase coverage by 0.00%.
The diff coverage is 66.66%.

❗ Current head 369c60d differs from pull request most recent head 5601e66. Consider uploading reports for the commit 5601e66 to get more accurate results

@@           Coverage Diff           @@
##             main    #1550   +/-   ##
=======================================
  Coverage   92.78%   92.78%           
=======================================
  Files         331      331           
  Lines       30674    30676    +2     
  Branches     3508     3508           
=======================================
+ Hits        28460    28462    +2     
  Misses       2214     2214           
Impacted Files Coverage Δ
...ckages/components/_private/overlay/src/Overlay.tsx 95.59% <66.66%> (+0.03%) ⬆️

@danranVm danranVm merged commit 05fdb30 into IDuxFE:main May 13, 2023
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants