Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pro:search): clicking search button should trigger value change #1557

Merged
merged 1 commit into from May 18, 2023

Conversation

sallerli1
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

点击搜索按钮会重置正在编辑的标签

What is the new behavior?

不应当重置,应当保存当前状态并触发值的修改

Other information

问题在于按钮的mousedown没有阻止冒泡,导致触发了useControl中的全局mousedown,导致了激活状态的变化

@idux-bot
Copy link

idux-bot bot commented May 17, 2023

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Merging #1557 (dc4610e) into main (b8cada3) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head dc4610e differs from pull request most recent head c3f2c32. Consider uploading reports for the commit c3f2c32 to get more accurate results

@@            Coverage Diff             @@
##             main    #1557      +/-   ##
==========================================
- Coverage   92.78%   92.78%   -0.01%     
==========================================
  Files         331      331              
  Lines       30665    30667       +2     
  Branches     3508     3508              
==========================================
  Hits        28454    28454              
- Misses       2211     2213       +2     
Impacted Files Coverage Δ
packages/pro/search/src/ProSearch.tsx 20.56% <0.00%> (-0.17%) ⬇️

@sallerli1 sallerli1 force-pushed the fix-pro-search-search-btn-mousedown branch from 1cca496 to c3f2c32 Compare May 18, 2023 02:08
@danranVm danranVm merged commit 324d74f into IDuxFE:main May 18, 2023
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants