Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pro:table): the empty is not rendered in the layout tool #1562

Merged
merged 1 commit into from May 26, 2023

Conversation

danranVm
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

  • 配置了 layoutable=false 的列,且为固定列的时候,布局设置面板会出现空状态
  • 修复了在小号表格场景下的分页器高度问题
  • 修复了嵌套子表格的边距问题
    • 请注意样式的改动,子表格多了一个 margin: -4px 28px; 的样式

What is the new behavior?

Other information

@idux-bot
Copy link

idux-bot bot commented May 25, 2023

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Merging #1562 (d5abf82) into main (64d9a34) will increase coverage by 0.00%.
The diff coverage is 80.95%.

❗ Current head d5abf82 differs from pull request most recent head b782aea. Consider uploading reports for the commit b782aea to get more accurate results

@@           Coverage Diff           @@
##             main    #1562   +/-   ##
=======================================
  Coverage   92.78%   92.78%           
=======================================
  Files         331      331           
  Lines       30674    30673    -1     
  Branches     3508     3508           
=======================================
  Hits        28460    28460           
+ Misses       2214     2213    -1     
Impacted Files Coverage Δ
packages/pro/search/src/ProSearch.tsx 20.56% <0.00%> (-0.17%) ⬇️
...ckages/components/_private/overlay/src/Overlay.tsx 96.75% <77.77%> (+1.20%) ⬆️
packages/components/config/src/defaultConfig.ts 100.00% <100.00%> (ø)
packages/components/config/src/types.ts 100.00% <100.00%> (ø)
packages/components/modal/src/ModalWrapper.tsx 79.42% <100.00%> (+0.21%) ⬆️
packages/components/modal/src/types.ts 100.00% <100.00%> (ø)

@danranVm danranVm merged commit ea62fd1 into IDuxFE:main May 26, 2023
5 of 7 checks passed
@danranVm danranVm deleted the fix-pro-table-layout branch June 27, 2023 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant