Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp:tabs): incorrect offset of the selected bar with dynamic tabs #1563

Merged
merged 1 commit into from May 26, 2023

Conversation

danranVm
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

  • type='line' 模式下,dataSource 动态变化的时候,选中的下划线偏移位置不正确。

What is the new behavior?

Other information

@idux-bot
Copy link

idux-bot bot commented May 26, 2023

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Merging #1563 (d05ea05) into main (64d9a34) will increase coverage by 0.00%.
The diff coverage is 80.95%.

❗ Current head d05ea05 differs from pull request most recent head fe174f5. Consider uploading reports for the commit fe174f5 to get more accurate results

@@           Coverage Diff           @@
##             main    #1563   +/-   ##
=======================================
  Coverage   92.78%   92.78%           
=======================================
  Files         331      331           
  Lines       30674    30673    -1     
  Branches     3508     3509    +1     
=======================================
  Hits        28460    28460           
+ Misses       2214     2213    -1     
Impacted Files Coverage Δ
packages/pro/search/src/ProSearch.tsx 20.56% <0.00%> (-0.17%) ⬇️
...ckages/components/_private/overlay/src/Overlay.tsx 96.75% <77.77%> (+1.20%) ⬆️
packages/components/config/src/defaultConfig.ts 100.00% <100.00%> (ø)
packages/components/config/src/types.ts 100.00% <100.00%> (ø)
packages/components/modal/src/ModalWrapper.tsx 79.42% <100.00%> (+0.21%) ⬆️
packages/components/modal/src/types.ts 100.00% <100.00%> (ø)

@danranVm danranVm merged commit 15be909 into IDuxFE:main May 26, 2023
5 of 7 checks passed
@danranVm danranVm deleted the fix-tabs-dynamic branch May 26, 2023 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant