Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(comp:tabs): support addIcon slot #1566

Merged
merged 1 commit into from May 29, 2023

Conversation

danranVm
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

  • 文档中的滑动 Demo 有 bug, 更多浮层展开后没有数据

What is the new behavior?

  • 新增了 addIcon 的插槽
  • 更多浮层展开数据显示正常
    image

Other information

@idux-bot
Copy link

idux-bot bot commented May 29, 2023

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Merging #1566 (d7a93c1) into main (08e1821) will not change coverage.
The diff coverage is 100.00%.

❗ Current head d7a93c1 differs from pull request most recent head e9de0e6. Consider uploading reports for the commit e9de0e6 to get more accurate results

@@           Coverage Diff           @@
##             main    #1566   +/-   ##
=======================================
  Coverage   92.78%   92.78%           
=======================================
  Files         331      331           
  Lines       30673    30673           
  Branches     3509     3509           
=======================================
  Hits        28460    28460           
  Misses       2213     2213           
Impacted Files Coverage Δ
packages/components/tabs/src/Tabs.tsx 87.50% <100.00%> (ø)
packages/components/tabs/src/tokens.ts 100.00% <100.00%> (ø)

@danranVm danranVm merged commit dcd9c1a into IDuxFE:main May 29, 2023
5 of 7 checks passed
@danranVm danranVm deleted the feat-tabs-addIcon branch May 29, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant