Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp:config): the weekStartsOn does not work in the enUS locale #1570

Merged
merged 1 commit into from Jun 3, 2023

Conversation

danranVm
Copy link
Member

@danranVm danranVm commented Jun 3, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

  • 在英语环境下,每周的起始日期不正确。

image

What is the new behavior?

Other information

@idux-bot
Copy link

idux-bot bot commented Jun 3, 2023

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jun 3, 2023

Codecov Report

Merging #1570 (f0cacb9) into main (c3721a5) will not change coverage.
The diff coverage is 100.00%.

❗ Current head f0cacb9 differs from pull request most recent head d729672. Consider uploading reports for the commit d729672 to get more accurate results

@@           Coverage Diff           @@
##             main    #1570   +/-   ##
=======================================
  Coverage   92.77%   92.77%           
=======================================
  Files         332      332           
  Lines       30690    30690           
  Branches     3509     3509           
=======================================
  Hits        28474    28474           
  Misses       2216     2216           
Impacted Files Coverage Δ
packages/components/config/src/dateConfig.ts 93.41% <100.00%> (ø)

@danranVm danranVm merged commit 0ce5cf4 into IDuxFE:main Jun 3, 2023
5 of 7 checks passed
@danranVm danranVm deleted the fix-date-config branch June 3, 2023 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant