Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp:select): the placeholder in overlay can't setting #1571

Merged
merged 1 commit into from Jun 5, 2023

Conversation

danranVm
Copy link
Member

@danranVm danranVm commented Jun 3, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

  • 设置 searchable=‘false’ 的时候,不能设置面板中搜索框的 placeholder

What is the new behavior?

Other information

@idux-bot
Copy link

idux-bot bot commented Jun 3, 2023

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jun 3, 2023

Codecov Report

Merging #1571 (890353f) into main (c3721a5) will decrease coverage by 0.01%.
The diff coverage is 66.66%.

❗ Current head 890353f differs from pull request most recent head a35bd1d. Consider uploading reports for the commit a35bd1d to get more accurate results

@@            Coverage Diff             @@
##             main    #1571      +/-   ##
==========================================
- Coverage   92.77%   92.77%   -0.01%     
==========================================
  Files         332      332              
  Lines       30690    30692       +2     
  Branches     3509     3509              
==========================================
+ Hits        28474    28475       +1     
- Misses       2216     2217       +1     
Impacted Files Coverage Δ
packages/components/select/src/Select.tsx 86.45% <0.00%> (-0.35%) ⬇️
packages/components/config/src/dateConfig.ts 93.41% <100.00%> (ø)
packages/components/select/src/types.ts 100.00% <100.00%> (ø)

@danranVm danranVm merged commit 7388dc4 into IDuxFE:main Jun 5, 2023
5 of 7 checks passed
@danranVm danranVm deleted the fix-style branch June 27, 2023 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant