Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp:select): the onSearch should be called when the intput is clear #1577

Merged
merged 1 commit into from Jun 27, 2023

Conversation

danranVm
Copy link
Member

@danranVm danranVm commented Jun 26, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

  • 设置 searchable = true 时,点击输入框的清除图标,不会触发 onSearch 事件,仅触发 onClear 事件
  • 设置 searchable = ’overlay‘ 时,点击浮层中输入框的清除图标,不会触发任何事件

What is the new behavior?

  • 现在都会触发 onSearch 事件,参数为 '' 空字符。
  • 受影响的组件有:Cascader, Select, TreeSelect

Other information

@idux-bot
Copy link

idux-bot bot commented Jun 26, 2023

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Merging #1577 (ad7f462) into main (feb5a33) will decrease coverage by 0.02%.
The diff coverage is 30.00%.

❗ Current head ad7f462 differs from pull request most recent head d6fdd9b. Consider uploading reports for the commit d6fdd9b to get more accurate results

@@            Coverage Diff             @@
##             main    #1577      +/-   ##
==========================================
- Coverage   92.77%   92.75%   -0.02%     
==========================================
  Files         332      332              
  Lines       30692    30695       +3     
  Branches     3509     3509              
==========================================
- Hits        28475    28472       -3     
- Misses       2217     2223       +6     
Impacted Files Coverage Δ
packages/components/select/src/Select.tsx 85.43% <0.00%> (-1.03%) ⬇️
packages/components/cascader/src/Cascader.tsx 83.87% <25.00%> (-1.18%) ⬇️
packages/components/notification/src/types.ts 100.00% <100.00%> (ø)

@danranVm danranVm merged commit ab4e4b0 into IDuxFE:main Jun 27, 2023
4 of 7 checks passed
@danranVm danranVm deleted the fix-searchable branch June 27, 2023 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant