Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp:modal): the size of button should be 'md' #1582

Merged
merged 1 commit into from Jun 28, 2023

Conversation

danranVm
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

  • Seer 主题下,Modal 的按钮默认为 ’sm‘

What is the new behavior?

  • 改为 md

Other information

@idux-bot
Copy link

idux-bot bot commented Jun 28, 2023

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Merging #1582 (748a2e0) into main (ab4e4b0) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 748a2e0 differs from pull request most recent head 1c5e4f5. Consider uploading reports for the commit 1c5e4f5 to get more accurate results

@@           Coverage Diff            @@
##             main    #1582    +/-   ##
========================================
  Coverage   92.76%   92.76%            
========================================
  Files         332      332            
  Lines       30695    30699     +4     
  Branches     3510     2568   -942     
========================================
+ Hits        28473    28477     +4     
  Misses       2222     2222            
Impacted Files Coverage Δ
packages/components/icon/src/dependencies.ts 99.18% <100.00%> (+0.01%) ⬆️
packages/components/modal/src/ModalWrapper.tsx 79.53% <100.00%> (+0.10%) ⬆️

@danranVm danranVm merged commit 00c7c6c into IDuxFE:main Jun 28, 2023
5 of 7 checks passed
@danranVm danranVm deleted the fix-modal branch June 28, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant