Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(comp:checkbox,radio): support fieldset slot #1608

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

danranVm
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

What is the new behavior?

  • checkbox 和 radio-group 组件支持 fieldset 插槽

Other information

@idux-bot
Copy link

idux-bot bot commented Jul 20, 2023

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #1608 (93b7fa2) into main (5a5eaea) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 93b7fa2 differs from pull request most recent head 44b8500. Consider uploading reports for the commit 44b8500 to get more accurate results

@@            Coverage Diff             @@
##             main    #1608      +/-   ##
==========================================
+ Coverage   92.56%   92.58%   +0.01%     
==========================================
  Files         338      338              
  Lines       31542    31602      +60     
  Branches     3601     3618      +17     
==========================================
+ Hits        29198    29258      +60     
  Misses       2344     2344              
Impacted Files Coverage Δ
packages/components/checkbox/src/Checkbox.tsx 98.15% <100.00%> (+0.11%) ⬆️
packages/components/radio/src/RadioGroup.tsx 100.00% <100.00%> (ø)

@danranVm danranVm merged commit 53c9131 into IDuxFE:main Jul 26, 2023
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant