Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pro:search): empty state should be determined by search states #1613

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

sallerli1
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

存在临时标签但value是空的时候,placeholder异常显示

What is the new behavior?

高级搜索的标签渲染直接与searchStates数据相关,空状态也应当根据searchStates判断

Other information

@idux-bot
Copy link

idux-bot bot commented Jul 25, 2023

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #1613 (ca4963c) into main (fdda882) will increase coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head ca4963c differs from pull request most recent head b7d0242. Consider uploading reports for the commit b7d0242 to get more accurate results

@@           Coverage Diff           @@
##             main    #1613   +/-   ##
=======================================
  Coverage   92.56%   92.57%           
=======================================
  Files         338      338           
  Lines       31542    31545    +3     
  Branches     3602     3602           
=======================================
+ Hits        29198    29202    +4     
+ Misses       2344     2343    -1     
Files Changed Coverage Δ
packages/pro/search/src/ProSearch.tsx 19.60% <0.00%> (-0.24%) ⬇️

... and 2 files with indirect coverage changes

@danranVm danranVm merged commit 25e755f into IDuxFE:main Jul 26, 2023
5 of 7 checks passed
@sallerli1 sallerli1 deleted the fix-pro-search-states-empty branch July 4, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants