Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp:tour): tour closable should be configurable #1622

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

sallerli1
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

closable不可配置

What is the new behavior?

增加closable配置

Other information

@idux-bot
Copy link

idux-bot bot commented Aug 3, 2023

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #1622 (7f3ced4) into main (b831b6b) will decrease coverage by 0.01%.
The diff coverage is 88.23%.

❗ Current head 7f3ced4 differs from pull request most recent head b6045f7. Consider uploading reports for the commit b6045f7 to get more accurate results

@@            Coverage Diff             @@
##             main    #1622      +/-   ##
==========================================
- Coverage   92.62%   92.61%   -0.01%     
==========================================
  Files         345      345              
  Lines       32160    32174      +14     
  Branches     3672     3674       +2     
==========================================
+ Hits        29788    29798      +10     
- Misses       2372     2376       +4     
Files Changed Coverage Δ
packages/components/tour/src/Panel.tsx 93.95% <81.81%> (-2.50%) ⬇️
packages/components/config/src/defaultConfig.ts 100.00% <100.00%> (ø)
packages/components/config/src/types.ts 100.00% <100.00%> (ø)
packages/components/tour/src/types.ts 100.00% <100.00%> (ø)

@sallerli1 sallerli1 merged commit 409c280 into IDuxFE:main Aug 4, 2023
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant