Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp:modal): header size should be sm when header has no content #1634

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

sallerli1
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

对话框header的尺寸不符合设计规范

What is the new behavior?

在header有内容的时候尺寸为md,无内容时尺寸为sm

Other information

@idux-bot
Copy link

idux-bot bot commented Aug 8, 2023

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #1634 (c4ab17d) into main (97bdafb) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head c4ab17d differs from pull request most recent head 52d3f8a. Consider uploading reports for the commit 52d3f8a to get more accurate results

@@           Coverage Diff           @@
##             main    #1634   +/-   ##
=======================================
  Coverage   92.62%   92.62%           
=======================================
  Files         345      345           
  Lines       32199    32204    +5     
  Branches     3677     3677           
=======================================
+ Hits        29825    29830    +5     
  Misses       2374     2374           
Files Changed Coverage Δ
packages/components/modal/src/ModalWrapper.tsx 79.79% <100.00%> (+0.26%) ⬆️

@sallerli1 sallerli1 merged commit ca74b62 into IDuxFE:main Aug 11, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant