Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp:select): responsive maxLabel size calculation error #1647

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

sallerli1
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

select组件的maxlabel配置responsive时,由于容器尺寸没有减去内边距以及使用了clientWidth,而clientWidth会省略掉小数,导致实际计算结果不准确,可能出现换行的情况

What is the new behavior?

修复以上问题

Other information

@idux-bot
Copy link

idux-bot bot commented Aug 10, 2023

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #1647 (1776e4f) into main (97bdafb) will decrease coverage by 0.04%.
The diff coverage is 72.22%.

❗ Current head 1776e4f differs from pull request most recent head 72a4e49. Consider uploading reports for the commit 72a4e49 to get more accurate results

@@            Coverage Diff             @@
##             main    #1647      +/-   ##
==========================================
- Coverage   92.62%   92.59%   -0.04%     
==========================================
  Files         345      345              
  Lines       32199    32257      +58     
  Branches     3677     3682       +5     
==========================================
+ Hits        29825    29869      +44     
- Misses       2374     2388      +14     
Files Changed Coverage Δ
...ages/components/_private/overflow/src/Overflow.tsx 82.56% <30.76%> (-5.55%) ⬇️
packages/cdk/utils/src/dom.ts 83.02% <95.45%> (+4.05%) ⬆️
packages/components/_private/overflow/src/Item.tsx 100.00% <100.00%> (ø)
packages/components/_private/overflow/src/types.ts 100.00% <100.00%> (ø)

@sallerli1 sallerli1 merged commit 468a749 into IDuxFE:main Aug 11, 2023
7 checks passed
@sallerli1 sallerli1 deleted the fix-overflow-size-calc branch July 4, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant