Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cdk:popper): reference is hidden when ancestors are not visible #1648

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

sallerli1
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

当父元素被隐藏,popper不会消失

What is the new behavior?

当父元素被隐藏时,referenceHidden应当是true

Other information

@idux-bot
Copy link

idux-bot bot commented Aug 10, 2023

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #1648 (80946b1) into main (97bdafb) will not change coverage.
The diff coverage is n/a.

❗ Current head 80946b1 differs from pull request most recent head 2fe0aea. Consider uploading reports for the commit 2fe0aea to get more accurate results

@@           Coverage Diff           @@
##             main    #1648   +/-   ##
=======================================
  Coverage   92.62%   92.62%           
=======================================
  Files         345      345           
  Lines       32199    32199           
  Branches     3677     3677           
=======================================
  Hits        29825    29825           
  Misses       2374     2374           

@sallerli1 sallerli1 force-pushed the fix-cdk-popper-referencehidden branch from 843bda6 to beeced2 Compare August 11, 2023 02:59
@sallerli1 sallerli1 force-pushed the fix-cdk-popper-referencehidden branch from beeced2 to 2fe0aea Compare August 11, 2023 09:16
@sallerli1 sallerli1 changed the title [WIP]fix(cdk:popper): reference is hidden when ancestors are not visible fix(cdk:popper): reference is hidden when ancestors are not visible Aug 11, 2023
@sallerli1 sallerli1 merged commit db00adb into IDuxFE:main Aug 11, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant