Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp:drawer): content first render should be delayed till visible #1657

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

sallerli1
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

Drawer的内容渲染应当延迟到首次visible之后,否则会导致内容内的组件mounted的时候实际上时隐藏的状态,尺寸获取不正确

What is the new behavior?

修复以上问题

Other information

@idux-bot
Copy link

idux-bot bot commented Aug 21, 2023

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Merging #1657 (302bf8f) into main (192ca82) will increase coverage by 0.00%.
Report is 5 commits behind head on main.
The diff coverage is 100.00%.

❗ Current head 302bf8f differs from pull request most recent head 02bb7cd. Consider uploading reports for the commit 02bb7cd to get more accurate results

@@           Coverage Diff           @@
##             main    #1657   +/-   ##
=======================================
  Coverage   92.59%   92.59%           
=======================================
  Files         345      345           
  Lines       32285    32292    +7     
  Branches     3685     3687    +2     
=======================================
+ Hits        29895    29902    +7     
  Misses       2390     2390           
Files Changed Coverage Δ
packages/components/drawer/src/Drawer.tsx 93.66% <100.00%> (+0.08%) ⬆️
packages/components/drawer/src/DrawerWrapper.tsx 83.28% <100.00%> (+0.15%) ⬆️
packages/components/drawer/src/token.ts 100.00% <100.00%> (ø)

@sallerli1 sallerli1 merged commit 4e4542b into IDuxFE:main Aug 21, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant