Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp:card): footer button style should use class but not button #1677

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

sallerli1
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

card组件中,.card-size使用了 button 指定元素样式,导致污染到内部自定义的button样式

What is the new behavior?

使用class而非button

Other information

@idux-bot
Copy link

idux-bot bot commented Sep 4, 2023

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Merging #1677 (c979a6e) into main (dc97ac1) will not change coverage.
The diff coverage is n/a.

❗ Current head c979a6e differs from pull request most recent head 0656811. Consider uploading reports for the commit 0656811 to get more accurate results

@@           Coverage Diff           @@
##             main    #1677   +/-   ##
=======================================
  Coverage   92.59%   92.59%           
=======================================
  Files         345      345           
  Lines       32285    32285           
  Branches     3688     3688           
=======================================
  Hits        29895    29895           
  Misses       2390     2390           

@sallerli1 sallerli1 merged commit cf91774 into IDuxFE:main Sep 4, 2023
7 checks passed
@sallerli1 sallerli1 deleted the fix-card-footer-button-cls-saller branch July 4, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant