Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(comp:text): rewrite component to provide better ellipsis support #1680

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

sallerli1
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

What is the new behavior?

重构text组件:

  1. 不再使用 lineClamp 实现多行缩进,改为使用动态渲染计算的方式
  2. 增加 expandIconcopyIcon 属性支持
  3. expanded 支持受控
  4. 增加 onCopy 事件
  5. 增加 ellipsissuffix 插槽,支持自定义省略号和后缀

Other information

@idux-bot
Copy link

idux-bot bot commented Sep 6, 2023

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #1680 (bba334b) into main (f6bed3c) will decrease coverage by 0.04%.
The diff coverage is 86.12%.

❗ Current head bba334b differs from pull request most recent head fbb0278. Consider uploading reports for the commit fbb0278 to get more accurate results

@@            Coverage Diff             @@
##             main    #1680      +/-   ##
==========================================
- Coverage   92.59%   92.56%   -0.04%     
==========================================
  Files         345      345              
  Lines       32286    32368      +82     
  Branches     3688     3690       +2     
==========================================
+ Hits        29896    29961      +65     
- Misses       2390     2407      +17     
Files Changed Coverage Δ
packages/components/config/src/seerConfig.ts 87.50% <75.00%> (-0.97%) ⬇️
packages/components/text/src/Text.tsx 82.51% <79.64%> (-7.30%) ⬇️
packages/components/config/src/defaultConfig.ts 100.00% <100.00%> (ø)
packages/components/config/src/types.ts 100.00% <100.00%> (ø)
packages/components/locales/src/types.ts 100.00% <100.00%> (ø)
packages/components/text/src/types.ts 100.00% <100.00%> (ø)
packages/components/tree/src/types.ts 99.66% <100.00%> (ø)

@sallerli1 sallerli1 merged commit fb1adb2 into IDuxFE:main Sep 8, 2023
3 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants