Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp:icon): three icon are added #1685

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Conversation

zhangliming0618
Copy link
Contributor

@zhangliming0618 zhangliming0618 commented Sep 14, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

The iDux component library has three new ICONS: fit-to-view, select, and thumbnail.
Link: https://idux.site/components/icon/zh
Screenshots:
image
image
image

What is the new behavior?

The iDux component library has three new ICONS: fit-to-view, select, and thumbnail.

Other information

No other information

@idux-bot
Copy link

idux-bot bot commented Sep 14, 2023

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #1685 (5a35f74) into main (dc97ac1) will decrease coverage by 0.05%.
Report is 16 commits behind head on main.
The diff coverage is 83.47%.

❗ Current head 5a35f74 differs from pull request most recent head 7ab20ca. Consider uploading reports for the commit 7ab20ca to get more accurate results

@@            Coverage Diff             @@
##             main    #1685      +/-   ##
==========================================
- Coverage   92.59%   92.55%   -0.05%     
==========================================
  Files         345      345              
  Lines       32285    32410     +125     
  Branches     3688     3692       +4     
==========================================
+ Hits        29895    29996     +101     
- Misses       2390     2414      +24     
Files Changed Coverage Δ
packages/pro/search/src/ProSearch.tsx 15.76% <0.00%> (-0.14%) ⬇️
packages/components/upload/src/Upload.tsx 48.83% <23.52%> (-1.17%) ⬇️
packages/components/config/src/seerConfig.ts 87.50% <75.00%> (-0.97%) ⬇️
packages/components/text/src/Text.tsx 82.51% <79.64%> (-7.30%) ⬇️
packages/components/config/src/defaultConfig.ts 100.00% <100.00%> (ø)
packages/components/config/src/types.ts 100.00% <100.00%> (ø)
packages/components/icon/src/definitions.ts 100.00% <100.00%> (ø)
packages/components/locales/src/types.ts 100.00% <100.00%> (ø)
packages/components/table/src/types.ts 100.00% <100.00%> (ø)
packages/components/tabs/src/types.ts 100.00% <100.00%> (ø)
... and 6 more

@sallerli1 sallerli1 merged commit bdb7ba1 into IDuxFE:main Sep 18, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants