Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp:text): use css ellipsis at one row to improve performance #1705

Merged
merged 1 commit into from Oct 7, 2023

Conversation

sallerli1
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

IxText组件在单页面内大量使用会导致内容出现卡顿问题

What is the new behavior?

在简单场景下,即只有单行且没有不可展开收起时,不再使用动态渲染模式,改用css的ellipsis

Other information

@idux-bot
Copy link

idux-bot bot commented Sep 27, 2023

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #1705 (0ab167b) into main (ffd204b) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head 0ab167b differs from pull request most recent head b32eb2c. Consider uploading reports for the commit b32eb2c to get more accurate results

@@            Coverage Diff             @@
##             main    #1705      +/-   ##
==========================================
- Coverage   92.54%   92.52%   -0.03%     
==========================================
  Files         345      345              
  Lines       32421    32427       +6     
  Branches     3693     3691       -2     
==========================================
- Hits        30005    30004       -1     
- Misses       2416     2423       +7     
Files Coverage Δ
packages/components/text/src/Text.tsx 78.30% <100.00%> (-3.12%) ⬇️

@sallerli1 sallerli1 merged commit 271ef83 into IDuxFE:main Oct 7, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant