Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(comp:*): all input components with overlay support focus and blu… #1714

Merged
merged 1 commit into from Oct 30, 2023

Conversation

sallerli1
Copy link
Contributor

…r event

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

IxSelect IxCascader IxTreeSelect 的 focus 和 blur 事件没有暴露,外部无法监听

What is the new behavior?

IxSelect IxCascader IxTreeSelect 新增 onFocus 和 onBlur,并优化浮层关闭的触发以及键盘操作设计
IxTimePicker IxDatePicker 优化浮层关闭触发

Other information

优化项:
浮层关闭触发:浮层不再以点击空白处关闭,而是在组件失焦后关闭
键盘操作:在浮层关闭的时候,按除了退格和tab键之外的键,都会展开浮层

@idux-bot
Copy link

idux-bot bot commented Oct 17, 2023

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #1714 (f8c9252) into main (47b21e0) will decrease coverage by 0.18%.
The diff coverage is 86.62%.

❗ Current head f8c9252 differs from pull request most recent head ce0dea8. Consider uploading reports for the commit ce0dea8 to get more accurate results

@@            Coverage Diff             @@
##             main    #1714      +/-   ##
==========================================
- Coverage   92.52%   92.35%   -0.18%     
==========================================
  Files         345      346       +1     
  Lines       32429    32695     +266     
  Branches     2712     2719       +7     
==========================================
+ Hits        30006    30194     +188     
- Misses       2423     2501      +78     
Files Coverage Δ
packages/components/_private/selector/src/token.ts 100.00% <ø> (ø)
packages/components/_private/selector/src/types.ts 100.00% <100.00%> (ø)
packages/components/cascader/src/types.ts 100.00% <100.00%> (ø)
packages/components/date-picker/src/token.ts 100.00% <100.00%> (ø)
packages/components/select/src/Select.tsx 86.79% <100.00%> (+1.35%) ⬆️
packages/components/select/src/types.ts 100.00% <100.00%> (ø)
packages/components/time-picker/src/tokens.ts 100.00% <100.00%> (ø)
packages/components/tree-select/src/types.ts 99.39% <100.00%> (+<0.01%) ⬆️
...ages/components/_private/selector/src/Selector.tsx 89.57% <75.00%> (-1.62%) ⬇️
packages/components/tree-select/src/TreeSelect.tsx 95.94% <95.23%> (+0.27%) ⬆️
... and 7 more

... and 3 files with indirect coverage changes

@sallerli1 sallerli1 merged commit 7b739aa into IDuxFE:main Oct 30, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant