Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(comp:drawer,header,message,modal,notification): all VNode props support render function now #1717

Merged

Conversation

sallerli1
Copy link
Contributor

…support render function now

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

以上组件的部分属性支持传入 VNode 进行自定义,但仅传入创建好的vnode会导致数据响应式问题

What is the new behavior?

针对以上组件,对类型支持 VNode 的属性进行扩展,支持传入一个类型为 () => VNodeChild 的渲染函数

Other information

@idux-bot
Copy link

idux-bot bot commented Oct 18, 2023

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #1717 (cce0e76) into main (47b21e0) will decrease coverage by 0.02%.
The diff coverage is 94.40%.

❗ Current head cce0e76 differs from pull request most recent head d093907. Consider uploading reports for the commit d093907 to get more accurate results

@@            Coverage Diff             @@
##             main    #1717      +/-   ##
==========================================
- Coverage   92.52%   92.51%   -0.02%     
==========================================
  Files         345      345              
  Lines       32429    32490      +61     
  Branches     2712     2720       +8     
==========================================
+ Hits        30006    30057      +51     
- Misses       2423     2433      +10     
Files Coverage Δ
packages/components/_private/footer/src/types.ts 100.00% <100.00%> (ø)
packages/components/config/src/types.ts 100.00% <100.00%> (ø)
packages/components/drawer/src/DrawerProvider.tsx 97.05% <100.00%> (+0.13%) ⬆️
packages/components/drawer/src/types.ts 100.00% <100.00%> (ø)
packages/components/header/src/types.ts 100.00% <100.00%> (ø)
packages/components/message/src/Message.tsx 100.00% <100.00%> (ø)
...ackages/components/message/src/MessageProvider.tsx 97.35% <100.00%> (+0.18%) ⬆️
packages/components/message/src/types.ts 100.00% <100.00%> (ø)
packages/components/modal/src/ModalProvider.tsx 97.18% <100.00%> (+0.12%) ⬆️
packages/components/modal/src/types.ts 100.00% <100.00%> (ø)
... and 5 more

@sallerli1 sallerli1 merged commit b44ad60 into IDuxFE:main Oct 30, 2023
7 checks passed
sallerli1 added a commit that referenced this pull request Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant