Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pro:search): unconfirmed item sequence should change when update #1725

Merged
merged 1 commit into from Oct 30, 2023

Conversation

sallerli1
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

新创建但未确认的搜索项,在其他搜索项被修改之后,顺序会发生变化,导致操作不友好

What is the new behavior?

修复以上问题

Other information

每次在值更新后初始化时,会用两个指针分别遍历已经确认的搜索值和未确认的搜索值,根据更新前记录的顺序将连续的未确认的搜索项插入,保证其在原有的位置

受控使用场景的出现频率明显低于这种场景,因此优先保证未确认搜索项的顺序

@idux-bot
Copy link

idux-bot bot commented Oct 30, 2023

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #1725 (4eb617b) into main (0b59f73) will not change coverage.
The diff coverage is n/a.

❗ Current head 4eb617b differs from pull request most recent head 9934401. Consider uploading reports for the commit 9934401 to get more accurate results

@@           Coverage Diff           @@
##             main    #1725   +/-   ##
=======================================
  Coverage   92.52%   92.52%           
=======================================
  Files         345      345           
  Lines       32431    32431           
  Branches     2712     2712           
=======================================
  Hits        30008    30008           
  Misses       2423     2423           

@sallerli1 sallerli1 merged commit 34f9669 into IDuxFE:main Oct 30, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant