Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp:text): text component should inherit attrs #1731

Merged
merged 1 commit into from Nov 3, 2023

Conversation

sallerli1
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

text 组件没有继承属性到根节点,导致无法覆盖修改样式

What is the new behavior?

修复以上问题

Other information

补充最大高度的demo

@idux-bot
Copy link

idux-bot bot commented Oct 31, 2023

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #1731 (c1978d4) into main (203ddee) will decrease coverage by 0.01%.
Report is 3 commits behind head on main.
The diff coverage is 36.36%.

❗ Current head c1978d4 differs from pull request most recent head 694049e. Consider uploading reports for the commit 694049e to get more accurate results

@@            Coverage Diff             @@
##             main    #1731      +/-   ##
==========================================
- Coverage   92.32%   92.31%   -0.01%     
==========================================
  Files         346      346              
  Lines       32778    32781       +3     
  Branches     2727     3704     +977     
==========================================
  Hits        30261    30261              
- Misses       2517     2520       +3     
Files Coverage Δ
packages/components/text/src/Text.tsx 78.49% <85.71%> (+0.18%) ⬆️
packages/pro/search/src/ProSearch.tsx 15.81% <13.33%> (+0.42%) ⬆️

@sallerli1 sallerli1 merged commit 75b49bf into IDuxFE:main Nov 3, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant