Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp:radio): gap behaves abnormally when configured without 0px #1740

Merged
merged 1 commit into from Nov 28, 2023

Conversation

threedayAAAAA
Copy link
Contributor

@threedayAAAAA threedayAAAAA commented Nov 24, 2023

fix #1684

PR Checklist

Please check if your PR fulfills the following requirements:

  • [-] The commit message follows our guidelines
  • [-] Tests for the changes have been added/updated or not needed
  • [-] Docs and demo have been added/updated or not needed

What is the current behavior?

IxRadioGroup的gap配置,对字符串和数字的处理不一致

What is the new behavior?

IxRadioGroup的gap配置为0px时与配置为0表现一致

Other information

Copy link

idux-bot bot commented Nov 24, 2023

This preview will be available after the AzureCI is passed.

Copy link

codecov bot commented Nov 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3692447) 92.31% compared to head (b635e42) 92.31%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1740   +/-   ##
=======================================
  Coverage   92.31%   92.31%           
=======================================
  Files         346      346           
  Lines       32786    32786           
  Branches     3709     3709           
=======================================
  Hits        30268    30268           
  Misses       2518     2518           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sallerli1 sallerli1 merged commit 9ecd14a into IDuxFE:main Nov 28, 2023
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]IxRadioGroup的gap配置,对字符串和数字的处理不一致
2 participants