Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp:desc): header component does not take effect #1742

Merged
merged 1 commit into from Nov 28, 2023

Conversation

threedayAAAAA
Copy link
Contributor

@threedayAAAAA threedayAAAAA commented Nov 27, 2023

fix #1710

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

Using the header slot header component does not take effect

What is the new behavior?

Using the header slot header component take effect

Other information

Copy link

idux-bot bot commented Nov 27, 2023

This preview will be available after the AzureCI is passed.

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (3692447) 92.31% compared to head (3d39bcd) 92.31%.

Files Patch % Lines
packages/components/desc/src/Desc.tsx 84.61% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1742      +/-   ##
==========================================
- Coverage   92.31%   92.31%   -0.01%     
==========================================
  Files         346      346              
  Lines       32786    32794       +8     
  Branches     3709     3710       +1     
==========================================
+ Hits        30268    30274       +6     
- Misses       2518     2520       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sallerli1 sallerli1 merged commit dd1aab8 into IDuxFE:main Nov 28, 2023
5 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[IxDesc ] desc header slots 不会独立成一行
2 participants