Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp:config): millisecond should be included in TimeConfigType #1850

Merged
merged 1 commit into from Feb 29, 2024

Conversation

sallerli1
Copy link
Contributor

startOf function should support TimeConfigType
endOf function should support TimeConfigType

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

  1. dateConifg 的 TimeConfigType 不支持 millisecond
  2. startOf 方法不支持 TimeConfigType
  3. endOf 方法不支持 TimeConfigType

What is the new behavior?

  1. TimeConfigType 新增 millisecond
  2. startOf 方法支持获取 hour, minute, second 的起点
  3. endOf 方法支持获取 hour, minute, second 的终点

Other information

startOf function should support TimeConfigType
endOf function should support TimeConfigType
Copy link

idux-bot bot commented Feb 29, 2024

This preview will be available after the AzureCI is passed.

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 70.96774% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 91.19%. Comparing base (e1a3a59) to head (d4e6a03).

Files Patch % Lines
packages/components/config/src/dateConfig.ts 70.96% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1850      +/-   ##
==========================================
- Coverage   91.21%   91.19%   -0.02%     
==========================================
  Files         348      348              
  Lines       34091    34119      +28     
  Branches     3730     3741      +11     
==========================================
+ Hits        31096    31115      +19     
- Misses       2995     3004       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sallerli1 sallerli1 merged commit 405b050 into IDuxFE:main Feb 29, 2024
5 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant