Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp:date-picker): range start and and date cover full range #1851

Merged
merged 1 commit into from Feb 29, 2024

Conversation

sallerli1
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

选择时间范围,起始的date均指向了0点0分0秒

What is the new behavior?

选择时间范围,开始时间应该指向日期的0点0分0秒,结束时间应当指向23点59分59秒999毫秒,覆盖完整的范围
针对月、周、年、季度的选择,同样覆盖完整的范围
选择具体的时间时,应当精确到时间的最小单位,例如面板中只支持选择小时和分钟,那要精确到分钟的起始,即开始时间应该是0秒0毫秒,结束时间应该是59秒999毫秒

Other information

Copy link

idux-bot bot commented Feb 29, 2024

This preview will be available after the AzureCI is passed.

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 89.28571% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 91.19%. Comparing base (405b050) to head (d8e2096).

Files Patch % Lines
packages/components/date-picker/src/utils.ts 87.83% 9 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1851   +/-   ##
=======================================
  Coverage   91.19%   91.19%           
=======================================
  Files         348      348           
  Lines       34119    34201   +82     
  Branches     3741     3755   +14     
=======================================
+ Hits        31115    31190   +75     
- Misses       3004     3011    +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sallerli1 sallerli1 merged commit 8174c4f into IDuxFE:main Feb 29, 2024
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant