Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp:theme): optimize global token update logic #1853

Merged
merged 1 commit into from Mar 4, 2024

Conversation

sallerli1
Copy link
Contributor

after global token update, all registered tokens should be updated, and global token key should be excluded
reset tokens shouldn't be explicitly updated because updating global tokens will trigger all token updates

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

全局token更新时,会触发所有的token更新,但是没有把global排除掉导致重复的计算
reset tokens 会在全局token更新后自动更新,但是也被显式重复更新了

What is the new behavior?

优化以上逻辑

Other information

after global token update, all registered tokens should be updated, and global token key should be excluded
reset tokens shouldn't be explicitly updated because updating global tokens will trigger all token updates
Copy link

idux-bot bot commented Feb 29, 2024

This preview will be available after the AzureCI is passed.

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.19%. Comparing base (8174c4f) to head (1885fec).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1853   +/-   ##
=======================================
  Coverage   91.19%   91.19%           
=======================================
  Files         348      348           
  Lines       34201    34201           
  Branches     3755     3754    -1     
=======================================
  Hits        31190    31190           
  Misses       3011     3011           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sallerli1 sallerli1 merged commit b89990c into IDuxFE:main Mar 4, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant