Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp:table): height of checkbox or radio in selectable column cell isn't right #1859

Merged
merged 1 commit into from Mar 5, 2024

Conversation

sallerli1
Copy link
Contributor

@sallerli1 sallerli1 commented Mar 5, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

表格的 selectable 列,checkbox和radio的高度不正常,导致showIndex开启之后,悬浮上去高度抖动

What is the new behavior?

将checkbox和radio的vertical-align设置为middle,并且在table-cell上加上类型相关的class,selectable column下的checkbox和radio的line-height均设置为1

Other information

Copy link

idux-bot bot commented Mar 5, 2024

This preview will be available after the AzureCI is passed.

@sallerli1 sallerli1 changed the title fix(comp:table): height of checkbox or radio in selectable column cel… fix(comp:table): height of checkbox or radio in selectable column cell isn't right Mar 5, 2024
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.19%. Comparing base (654ad1a) to head (1cb32c6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1859   +/-   ##
=======================================
  Coverage   91.19%   91.19%           
=======================================
  Files         349      349           
  Lines       34269    34269           
  Branches     3764     3764           
=======================================
  Hits        31250    31250           
  Misses       3019     3019           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sallerli1 sallerli1 force-pushed the fix-table-selectable-height branch from 6bc14a8 to 1cb32c6 Compare March 5, 2024 09:19
@sallerli1 sallerli1 merged commit 690fab8 into IDuxFE:main Mar 5, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant