Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp:spin): spin mask background color isn't correct #1874

Merged
merged 1 commit into from Apr 8, 2024

Conversation

sallerli1
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

通过 useSpin 创建的spin,其背景颜色不正确

What is the new behavior?

  1. 修改原本通过opacity实现的spin背景为背景颜色,并提供主题变量配置
  2. 修改通过 useSpin 创建的 spin 背景颜色,和直接使用 IxSpin 一致

Other information

Copy link

idux-bot bot commented Apr 8, 2024

This preview will be available after the AzureCI is passed.

Copy link

codecov bot commented Apr 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.79%. Comparing base (49eb4ea) to head (4c34f68).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1874   +/-   ##
=======================================
  Coverage   90.79%   90.79%           
=======================================
  Files         359      359           
  Lines       35225    35227    +2     
  Branches     2805     2805           
=======================================
+ Hits        31981    31983    +2     
  Misses       3244     3244           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sallerli1 sallerli1 merged commit f2fcf2d into IDuxFE:main Apr 8, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant