Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp:tree-select): removing item from selector doesn't uncheck tree node #1877

Merged
merged 1 commit into from Apr 8, 2024

Conversation

sallerli1
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

从选择框中移除已选项,不会同步取消树的勾选

What is the new behavior?

  1. 使用 components/utils 中的 useTreeCheckStateResolver 重构 tree 组件的勾选计算逻辑
  2. 在从选择框中移除选项后,应该调用树的勾选触发函数,根据级联策略计算取消该项勾选后的value

Other information

Copy link

idux-bot bot commented Apr 8, 2024

This preview will be available after the AzureCI is passed.

Copy link

codecov bot commented Apr 8, 2024

Codecov Report

Attention: Patch coverage is 69.23077% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 90.78%. Comparing base (49eb4ea) to head (b5e2ba6).
Report is 5 commits behind head on main.

Files Patch % Lines
packages/components/tree/src/Tree.tsx 57.89% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1877      +/-   ##
==========================================
- Coverage   90.79%   90.78%   -0.01%     
==========================================
  Files         359      359              
  Lines       35225    35242      +17     
  Branches     2805     2808       +3     
==========================================
+ Hits        31981    31996      +15     
- Misses       3244     3246       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sallerli1 sallerli1 merged commit ce4f477 into IDuxFE:main Apr 8, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant