Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pro:tag-select): supports beforeRemoveConfirm and beforeSelectConfirm #1879

Merged
merged 1 commit into from Apr 8, 2024

Conversation

sallerli1
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

What is the new behavior?

新增支持 beforeRemoveConfirm 和 beforeSelectConfirm,用来判断在移除和选择标签数据时是否可以确认

Other information

Copy link

idux-bot bot commented Apr 8, 2024

This preview will be available after the AzureCI is passed.

@sallerli1 sallerli1 force-pushed the fix-pro-tag-select-before-confirm branch from b7d0e98 to 6756667 Compare April 8, 2024 06:10
@sallerli1 sallerli1 force-pushed the fix-pro-tag-select-before-confirm branch from 6756667 to 641c8a9 Compare April 8, 2024 06:16
Copy link

codecov bot commented Apr 8, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 90.78%. Comparing base (d2fcdbf) to head (641c8a9).
Report is 2 commits behind head on main.

Files Patch % Lines
packages/pro/tag-select/src/ProTagSelect.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1879      +/-   ##
==========================================
- Coverage   90.78%   90.78%   -0.01%     
==========================================
  Files         359      359              
  Lines       35243    35249       +6     
  Branches     2808     2808              
==========================================
+ Hits        31997    32002       +5     
- Misses       3246     3247       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sallerli1 sallerli1 merged commit 4f48690 into IDuxFE:main Apr 8, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant