Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cdk:resizable): position should be set at start of resizing #1889

Merged
merged 1 commit into from Apr 12, 2024

Conversation

sallerli1
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

  1. 拖动开始的时候没有设置position,这期间如果元素的尺寸发生变化,之前记录的position并不会更新,如果仅仅点击边界不拖动,会让缩放异常进行
  2. 只有在拖动的时候才设置resizing为true

What is the new behavior?

拖动开始的时候就设置position,并设置 resizing 为 true

Other information

Copy link

idux-bot bot commented Apr 9, 2024

This preview will be available after the AzureCI is passed.

Copy link

codecov bot commented Apr 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.78%. Comparing base (96492f8) to head (a191a5d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1889   +/-   ##
=======================================
  Coverage   90.78%   90.78%           
=======================================
  Files         359      359           
  Lines       35249    35249           
  Branches     2807     2808    +1     
=======================================
  Hits        32002    32002           
  Misses       3247     3247           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sallerli1 sallerli1 merged commit aaf85b6 into IDuxFE:main Apr 12, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant