Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pro:textarea): height isn't correct when rows is set #1894

Merged
merged 1 commit into from Apr 17, 2024

Conversation

sallerli1
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

配置了 rows 之后,高度不正确,没有任何输入依然会出现滚动条

What is the new behavior?

Other information

Copy link

idux-bot bot commented Apr 17, 2024

This preview will be available after the AzureCI is passed.

Copy link

codecov bot commented Apr 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 90.74%. Comparing base (c6727d9) to head (f69fa66).

Files Patch % Lines
packages/pro/textarea/src/ProTextarea.tsx 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1894      +/-   ##
==========================================
- Coverage   90.77%   90.74%   -0.03%     
==========================================
  Files         359      359              
  Lines       35256    35264       +8     
  Branches     2807     2807              
==========================================
  Hits        32002    32002              
- Misses       3254     3262       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sallerli1 sallerli1 merged commit a2a7c77 into IDuxFE:main Apr 17, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant