Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp:select): selector input value should be emptied after blur #1941

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

sallerli1
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

单选场景下,在配置了searchable之后,在选择框中输入搜索内容,失焦之后输入的内容没有清空并且input元素遮挡了选中的内容

What is the new behavior?

修复以上问题

Other information

在失焦之后清空输入,并且仅在input不处于可输入状态且没有输入内容时才隐藏,并且仅当可输入(allowInput, searchable)时才设置输入内容

Copy link

idux-bot bot commented Jun 12, 2024

This preview will be available after the AzureCI is passed.

Copy link

codecov bot commented Jun 12, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 90.71%. Comparing base (403b2ca) to head (cd028c2).

Files Patch % Lines
packages/components/select/src/Select.tsx 20.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1941      +/-   ##
==========================================
- Coverage   90.71%   90.71%   -0.01%     
==========================================
  Files         360      360              
  Lines       35595    35598       +3     
  Branches     2843     2843              
==========================================
  Hits        32291    32291              
- Misses       3304     3307       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sallerli1 sallerli1 merged commit 502d8ce into IDuxFE:main Jun 12, 2024
8 of 9 checks passed
@sallerli1 sallerli1 deleted the fix-select-search-input-single branch July 4, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant