Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cdk:scroll): virtual scroll start offset should add size of prepended items #1950

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

sallerli1
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

当虚拟滚动传入了 colModifier 和 rowModifier 时,滚动的offset值应当加上被添加到行首或者列首的元素尺寸,保证滚动的内容区的offset正确,否则会造成滚动位置跳跃的情况

What is the new behavior?

修复以上问题

Other information

Copy link

idux-bot bot commented Jul 4, 2024

This preview will be available after the AzureCI is passed.

Copy link

codecov bot commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.70%. Comparing base (9c81358) to head (7913777).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1950   +/-   ##
=======================================
  Coverage   90.70%   90.70%           
=======================================
  Files         360      360           
  Lines       35595    35595           
  Branches     3863     3863           
=======================================
  Hits        32286    32286           
  Misses       3309     3309           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sallerli1 sallerli1 merged commit 28a6724 into IDuxFE:main Jul 4, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant