Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(comp: tree-select): add tree-select comp #606

Merged
merged 1 commit into from
Dec 21, 2021

Conversation

liuzaijiang
Copy link
Contributor

@liuzaijiang liuzaijiang commented Dec 11, 2021

PR Checklist

Please check if your PR fulfills the following requirements:
fix #557

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Component style update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

What is the new behavior?

Other information

@idux-bot
Copy link

idux-bot bot commented Dec 11, 2021

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Dec 12, 2021

Codecov Report

Merging #606 (3edd1c0) into main (d13e452) will increase coverage by 0.40%.
The diff coverage is 89.86%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #606      +/-   ##
==========================================
+ Coverage   83.08%   83.49%   +0.40%     
==========================================
  Files         370      385      +15     
  Lines        9337     9706     +369     
  Branches     2154     2230      +76     
==========================================
+ Hits         7758     8104     +346     
- Misses       1579     1602      +23     
Impacted Files Coverage Δ
packages/components/icon/src/dependencies.ts 100.00% <ø> (ø)
packages/components/tree/src/types.ts 85.71% <ø> (ø)
packages/components/tree-select/src/types.ts 66.66% <66.66%> (ø)
...ges/components/tree-select/src/content/Content.tsx 73.43% <73.43%> (ø)
...nents/tree-select/src/composables/useDataSource.ts 78.00% <78.00%> (ø)
...nents/tree-select/src/composables/useGetNodeKey.ts 80.00% <80.00%> (ø)
...ckages/components/tree-select/src/trigger/Item.tsx 80.00% <80.00%> (ø)
...kages/components/tree-select/src/trigger/Input.tsx 92.85% <92.85%> (ø)
...ges/components/tree-select/src/trigger/Trigger.tsx 94.59% <94.59%> (ø)
...ts/tree-select/src/composables/useSelectedState.ts 95.45% <95.45%> (ø)
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d13e452...3edd1c0. Read the comment docs.

@liuzaijiang liuzaijiang force-pushed the feat-tree-select-lzj branch 2 times, most recently from 3fd3196 to 3e31512 Compare December 19, 2021 07:25
@liuzaijiang liuzaijiang changed the title [wip]feat(comp: tree-select): add tree-select comp feat(comp: tree-select): add tree-select comp Dec 19, 2021
@liuzaijiang liuzaijiang force-pushed the feat-tree-select-lzj branch 2 times, most recently from 0710bab to 48ef6ca Compare December 20, 2021 01:01
Comment on lines +174 to +175
'tree-expand',
'tree-unexpand',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这两个 icon 的名字改一下吧。

@@ -61,6 +61,8 @@
@textarea-prefix: ~'@{idux-prefix}-textarea';
@time-picker-prefix: ~'@{idux-prefix}-time-picker';
@time-range-picker-prefix: ~'@{idux-prefix}-time-range-picker';
@tree-select-prefix: ~'@{idux-prefix}-tree-select';
@tree-select-option-prefix: ~'@{idux-prefix}-tree-select-option';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个没有用到吧。

@danranVm danranVm merged commit a8cc003 into IDuxFE:main Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[comp: tree select]: 新增树型选择组件
2 participants