feat(comp:carousel): add carousel component #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This preview will be available after the AzureCI is passed. |
Codecov Report
@@ Coverage Diff @@
## main #634 +/- ##
==========================================
+ Coverage 83.09% 83.64% +0.55%
==========================================
Files 370 393 +23
Lines 9338 9849 +511
Branches 2154 2268 +114
==========================================
+ Hits 7759 8238 +479
- Misses 1579 1611 +32
Continue to review full report at Codecov.
|
danranVm
requested changes
Dec 21, 2021
| } | ||
|
|
||
| export interface CarouselBindings { | ||
| next: () => void |
| @@ -0,0 +1,11 @@ | |||
| .vertical-center () { | |||
There was a problem hiding this comment.
Suggested change
| .vertical-center () { | |
| .carousel-vertical-center () { |
| transform: translateY(-50%); | ||
| } | ||
|
|
||
| .horizontal-center () { |
There was a problem hiding this comment.
Suggested change
| .horizontal-center () { | |
| .carousel-horizontal-center () { |
Comment on lines
110
to
119
| const dot = | ||
| slots.dot?.({ activeIndex: activeIndex.value }) ?? | ||
| Array.from({ length: length.value }).map((_, index: number) => { | ||
| const isActive = index + 1 === activeIndex.value | ||
| const itemClass = { | ||
| [`${prefixCls}-dot-item`]: true, | ||
| [`${prefixCls}-dot-item--active`]: isActive, | ||
| } | ||
| return <div class={itemClass} onClick={() => onClick(index)} onMouseenter={() => onMouseenter(index)}></div> | ||
| }) |
There was a problem hiding this comment.
Suggested change
| const dot = | |
| slots.dot?.({ activeIndex: activeIndex.value }) ?? | |
| Array.from({ length: length.value }).map((_, index: number) => { | |
| const isActive = index + 1 === activeIndex.value | |
| const itemClass = { | |
| [`${prefixCls}-dot-item`]: true, | |
| [`${prefixCls}-dot-item--active`]: isActive, | |
| } | |
| return <div class={itemClass} onClick={() => onClick(index)} onMouseenter={() => onMouseenter(index)}></div> | |
| }) | |
| const dots = Array.from({ length: length.value }).map((_, index: number) => { | |
| const isActive = index + 1 === activeIndex.value | |
| const itemClass = { | |
| [`${prefixCls}-dot-item`]: true, | |
| [`${prefixCls}-dot-item--active`]: isActive, | |
| } | |
| const children = slots.dot ? slots.dot({index, isActive}) : <button>{index}<button> | |
| return <li class={itemClass} onClick={() => onClick(index)} onMouseenter={() => onMouseenter(index)}>{children}</li> | |
| }) |
There was a problem hiding this comment.
这个插槽不应该是真对整个区域吧，而就是 dot 的内容？ 否则 还得自己加 item 的 class， 比较麻烦。
| </div> | ||
| </> | ||
| )} | ||
| {dotPlacement.value !== 'none' && <div class={dotClass.value}>{dot}</div>} |
There was a problem hiding this comment.
Suggested change
| {dotPlacement.value !== 'none' && <div class={dotClass.value}>{dot}</div>} | |
| {dotPlacement.value !== 'none' && <ul class={dotClass.value}>{dots}</ul>} |
其实我更建议把这个代码拆成一个子组件。
danranVm
reviewed
Dec 21, 2021
| category: components | ||
| type: 数据展示 | ||
| title: Carousel | ||
| subtitle: 走马灯（轮播图） |
There was a problem hiding this comment.
Suggested change
| subtitle: 走马灯（轮播图） | |
| subtitle: 轮播图 |
brenner8023
force-pushed
the
feat-carousel
branch
from
759786a
to
ef791ec
Compare
brenner8023
force-pushed
the
feat-carousel
branch
from
ef791ec
to
29ae7a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #230
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
add carousel component
What is the new behavior?
IxCarousel
CarouselProps
autoplayTimenumber00时不开启自动轮播dotPlacement'top' | 'start' | 'bottom' | 'end' | 'none''bottom''none'时不显示面板指示点showArrowprev、next按钮booleanfalsetrigger'click' | 'hover''click'onChange(prevIndex: number, nextIndex: number) => voidCarouselSlots
defaultdotactiveIndex: numberactiveIndex表示当前激活的面板索引arrowtype: 'prev' | 'next'CarseouselMethods
goTo(slideIndex: number)(slideIndex: number) => voidnext()prev()Other information