Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(comp:drawer,modal): add onBeforeClose event #647

Merged
merged 1 commit into from
Dec 22, 2021
Merged

feat(comp:drawer,modal): add onBeforeClose event #647

merged 1 commit into from
Dec 22, 2021

Conversation

danranVm
Copy link
Member

BREAKING CHANGE: onBeforeClose is used instead of onClose

fix #645

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Component style update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

What is the new behavior?

Other information

BREAKING CHANGE: onBeforeClose is used instead of onClose

fix #645
@idux-bot
Copy link

idux-bot bot commented Dec 22, 2021

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Dec 22, 2021

Codecov Report

Merging #647 (dc8b1f8) into main (bfbaa1d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #647   +/-   ##
=======================================
  Coverage   83.64%   83.64%           
=======================================
  Files         393      393           
  Lines        9849     9851    +2     
  Branches     2268     2268           
=======================================
+ Hits         8238     8240    +2     
  Misses       1611     1611           
Impacted Files Coverage Δ
packages/components/drawer/src/types.ts 100.00% <ø> (ø)
packages/components/modal/src/types.ts 100.00% <ø> (ø)
packages/components/drawer/src/Drawer.tsx 93.24% <100.00%> (+0.09%) ⬆️
packages/components/modal/src/Modal.tsx 98.52% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfbaa1d...dc8b1f8. Read the comment docs.

@danranVm danranVm merged commit a45e450 into IDuxFE:main Dec 22, 2021
@danranVm danranVm deleted the feat-drawer-before-colose branch December 22, 2021 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[comp:IxDrawer]onClose建议改成beforeClose
1 participant