-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(comp:upload): add file upload component #669
Conversation
This preview will be available after the AzureCI is passed. |
Codecov Report
@@ Coverage Diff @@
## main #669 +/- ##
==========================================
+ Coverage 85.34% 85.46% +0.12%
==========================================
Files 402 420 +18
Lines 10131 10673 +542
Branches 2373 2507 +134
==========================================
+ Hits 8646 9122 +476
- Misses 1485 1551 +66
Continue to review full report at Codecov.
|
dd74fdb
to
2f1d01b
Compare
2f1d01b
to
55d5241
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
重点 review 了 API 的设计,代码实现细节我就没有仔细看了。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我发现三种类型对应的子组件其实也是差不多的,只不过是 item 不一样,我建议是不是抽 3 个不的 item 就好了。
55d5241
to
0d15b57
Compare
三种类型相互之间存在不止item上的细节差异(比如 |
@danranVm review已修改,请查看 |
0d15b57
to
b8281a5
Compare
fa3e932
to
f3bf63c
Compare
f3bf63c
to
53a52ac
Compare
fix #605
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
add file upload component
Other information