Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cdk:forms): add default messages #689

Merged
merged 1 commit into from
Dec 30, 2021

Conversation

danranVm
Copy link
Member

@danranVm danranVm commented Dec 30, 2021

fix #684

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Component style update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

What is the new behavior?

Other information

@idux-bot
Copy link

idux-bot bot commented Dec 30, 2021

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Dec 30, 2021

Codecov Report

Merging #689 (d36a1d1) into main (7056a40) will decrease coverage by 0.12%.
The diff coverage is 68.96%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #689      +/-   ##
==========================================
- Coverage   83.93%   83.81%   -0.13%     
==========================================
  Files         394      396       +2     
  Lines        9899     9964      +65     
  Branches     2281     2299      +18     
==========================================
+ Hits         8309     8351      +42     
- Misses       1590     1613      +23     
Impacted Files Coverage Δ
packages/components/form/src/FormItem.tsx 25.86% <0.00%> (-0.46%) ⬇️
packages/components/space/src/types.ts 100.00% <ø> (ø)
packages/components/time-picker/src/types.ts 100.00% <ø> (ø)
packages/cdk/forms/src/messages/en-US.ts 34.48% <34.48%> (ø)
packages/cdk/forms/src/messages/zh-CN.ts 93.10% <93.10%> (ø)
packages/cdk/forms/src/controls.ts 100.00% <100.00%> (ø)
packages/cdk/forms/src/validators.ts 100.00% <100.00%> (ø)
packages/components/anchor/src/Anchor.tsx 96.15% <0.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7056a40...d36a1d1. Read the comment docs.

@danranVm danranVm merged commit 22d45d6 into IDuxFE:main Dec 30, 2021
@danranVm danranVm deleted the feat-cdk-forms-default-message branch December 30, 2021 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[cdk:forms] 内置校验函数没有提供默认提示信息
1 participant