Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(comp:pagination): remove itemRender and totalRender #695

Merged
merged 1 commit into from
Dec 30, 2021

Conversation

danranVm
Copy link
Member

@danranVm danranVm commented Dec 30, 2021

BREAKING CHANGE: itemRender and totalRender have been removed

re #658

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Component style update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

What is the new behavior?

Other information

BREAKING CHANGE: itemRender and totalRender have been removed

re IDuxFE#658
@idux-bot
Copy link

idux-bot bot commented Dec 30, 2021

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Dec 30, 2021

Codecov Report

Merging #695 (a5c9997) into main (1461a0e) will increase coverage by 1.52%.
The diff coverage is 96.70%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #695      +/-   ##
==========================================
+ Coverage   83.82%   85.35%   +1.52%     
==========================================
  Files         396      396              
  Lines        9972     9939      -33     
  Branches     2301     2297       -4     
==========================================
+ Hits         8359     8483     +124     
+ Misses       1613     1456     -157     
Impacted Files Coverage Δ
packages/components/config/src/defaultConfig.ts 100.00% <ø> (ø)
packages/components/pagination/src/token.ts 100.00% <ø> (ø)
packages/components/pagination/src/types.ts 100.00% <ø> (ø)
.../components/pagination/src/composables/usePages.ts 87.50% <87.50%> (ø)
packages/components/pagination/src/Pagination.tsx 100.00% <100.00%> (+78.43%) ⬆️
.../components/pagination/src/composables/useItems.ts 100.00% <100.00%> (ø)
...components/pagination/src/composables/useJumpTo.ts 100.00% <100.00%> (ø)
...ckages/components/pagination/src/contents/Item.tsx 100.00% <100.00%> (ø)
...ages/components/pagination/src/contents/Jumper.tsx 100.00% <100.00%> (ø)
...kages/components/pagination/src/contents/Sizes.tsx 100.00% <100.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1461a0e...a5c9997. Read the comment docs.

@danranVm danranVm merged commit e2dccc6 into IDuxFE:main Dec 30, 2021
@danranVm danranVm deleted the refacotor-pagination- branch December 30, 2021 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant